Garbled IPv6 printout

[Gary E. Miller]

Yo Hal!

On Sat, 30 Mar 2019 14:35:18 -0700
Hal Murray via devel <devel at ntpsec.org> wrote:

> I just pushed a fix.  It was an interesting quirk.

Looks good to me:

2019-03-30T15:02:20 ntpd[5666]: NTSc: nts_probe connecting to kong.rellim.com:12
3 => [2001:470:e815:0:225:90ff:fef3:55da]:123

I also see the ntp server port from NTS:

2019-03-30T15:04:40 ntpd[31301]: NTSc: Using port 11123

> There is a tool.  I forget the name.  I'd probably run it

valgrind, like this:
	valgrind --tool=memcheck ntpd -nN

It yields live data like:

==8341== Conditional jump or move depends on uninitialised value(s)
==8341==    at 0x4C35744: memmove (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==8341==    by 0x13D875: memcpy (string_fortified.h:34)
==8341==    by 0x13D875: extens_client_recv (nts_extens.c:362)
==8341==    by 0x125BD5: receive (ntp_proto.c:719)
==8341==    by 0x11C7AF: read_network_packet (ntp_io.c:2233)
==8341==    by 0x11DE9D: input_handler (ntp_io.c:2363)
==8341==    by 0x11DE9D: io_handler (ntp_io.c:2270)
==8341==    by 0x12B69D: mainloop (ntpd.c:933)
==8341==    by 0x12B69D: ntpdmain (ntpd.c:913)
==8341==    by 0x12B7DC: main (ntpd.c:422)

When you ^C you get a leak report like this:

==8341== 
==8341== HEAP SUMMARY:
==8341==     in use at exit: 75,519 bytes in 543 blocks
==8341==   total heap usage: 5,007 allocs, 4,464 frees, 1,360,368 bytes allocated
==8341== 
==8341== LEAK SUMMARY:
==8341==    definitely lost: 47 bytes in 8 blocks
==8341==    indirectly lost: 0 bytes in 0 blocks
==8341==      possibly lost: 21,680 bytes in 6 blocks
==8341==    still reachable: 53,792 bytes in 529 blocks
==8341==         suppressed: 0 bytes in 0 blocks
==8341== Rerun with --leak-check=full to see details of leaked memory
==8341== 
==8341== For counts of detected and suppressed errors, rerun with: -v
==8341== Use --track-origins=yes to see where uninitialised values come from
==8341== ERROR SUMMARY: 8641 errors from 513 contexts (suppressed: 0 from 0)


RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 851 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20190330/06612c1d/attachment.bin>