NTS update

[Matthew Selsky]

On Fri, Mar 22, 2019 at 04:52:33PM -0700, Gary E. Miller via devel wrote:
> Yo Hal!
> 
> New issue.  I have a really old server that has been running NTPsec
> git head until recently.  Now it fails, the openssl is too old.
> 
> # openssl version
> OpenSSL 1.0.2o  27 Mar 2018
> 
> I know I can update the openssl, but many people will not be able to...
> 
> How do I disable building with openssl?
> 
> The problem starts here:
> 
> [137/137] Linking build/main/ntptime/ntptime
> /usr/local/ssl/lib/libssl.a(t1_lib.o): In function `tls1_check_chain':
> t1_lib.c:(.text+0x6e96): undefined reference to `X509_certificate_type'
> /usr/local/ssl/lib/libssl.a(t1_lib.o): In function `SSL_check_chain':
> t1_lib.c:(.text+0x7ba3): undefined reference to `X509_certificate_type'
> /usr/local/ssl/lib/libssl.a(t1_enc.o): In function `tls1_change_cipher_state':
> t1_enc.c:(.text+0x715): undefined reference to `COMP_CTX_free'
> t1_enc.c:(.text+0x735): undefined reference to `COMP_CTX_new'
> t1_enc.c:(.text+0xac4): undefined reference to `COMP_CTX_free'
> t1_enc.c:(.text+0xae0): undefined reference to `COMP_CTX_new'

Gary,

This sounds like:
https://ubuntuforums.org/archive/index.php/t-985136.html

"The solution is simple, for some reason, when linking the library, -lssl must be in front of -lcrypto."

Can you run "./waf build -v" to confirm the order of the linker arguments?  And then swap them to confirm the fix?

I'd be happy to rejigger the wscript files once you confirm the fix itself.


Thanks,
-Matt