Mode 6 filter removal considered harmful

[James Browning]

On Sat, Mar 16, 2019 at 11:33 AM Achim Gratz via devel <devel at ntpsec.org>
wrote:

>
> As already briefly mentioned on IRC, the way the mode 6 messaging was
> changed to do no filtering at all anymore doesn't really work nicely.
> To wit here are two otherwise identical systems, one with and the other
> without those changes getting asked for their system variables:
>
:::snip:::

> Can the offending two commits (ee4ce108 removes the filtering, 4c5a32fb
> removes the flag bits the filtering was based on) be reverted and
> something more sensible be discussed here and then implemented.  And no,
> neither is the first commit a "Feature", quite the contrary, nor the
> second a "Refactor".  Both remove a feature or code, don't add or
> re-arrange.
>
> I haven't checked extensively if the list feature still works that
> allows to flag a user-selected set of variables for output, which can
> then be used with rl / cl variants of the cv / rv commands; the basics
> still seem to be there.  One of the problems is that there is only one
> list that gets applied to both the system and the clock variables.  So a
> useful feature would be if such lists could be named.  If that feature
> works, then predefined lists containing all system and clock variables
> (the output of a query for sys_var_list on the appropriate association
> ID) could be provided to achieve the "no filters" output more easily and
> directly.  Alternatively, extra variants for rv and cv could be provided
> to do the two queries for the user.
>
>
> Regards,
> Achim.
>
:::snip:::

(re)posted to
https://gitlab.com/NTPsec/ntpsec/merge_requests/963#note_151166759
which is probably not what you want.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20190316/c0d96bb3/attachment.html>