Clock variables for DCF77

[Achim Gratz]

Achim Gratz via devel writes:
> In general, I think coverity was getting hung up on the result of ap()
> getting assigned to the same pointer that it got as argument, which is
> actually not fixed in all places (see the start of the diff for one
> instance).

Actually, the places where this was changed probably indicates that
Coverity was warning about an assignment whose result was going unused
(i.e. the new position in the buffer) since there was no further append.
I posit that the result of changing the code based on that warning
actually creates a bug magnet instead, since you will now have to figure
out exactly when the last use of some variable is and if you later
happen to add some code that does use it again you'll have to remember
to put the assignment back in.

The bug here was that the assignment was removed from function calls
that do create a wholly new pointer that happened to re-use the same
pointer and then literally the next call clobbered the old one.  What
coverity might have warned about in those places is a mystery to me.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada