another changed behaviour

[Gary E. Miller]

Yo Achim!

On Mon, 04 Feb 2019 21:37:35 +0100
Achim Gratz via devel <devel at ntpsec.org> wrote:

> Udo van den Heuvel via devel writes:
> > I noticed that using latest git for ntpsec `/bin/ntpq -c
> > kerninfo|/bin/awk -e '/pll offset:/ {o=$3; if (o < 0) o = -o; print
> > o*1000000;}' -e '/estimated error/ {print $3*1000000;print 1;print
> > "ntpstat"}'` does no longer provide me with a pll offset nor an
> > estimated error.  

No need to get that complicated, just this fails:

 # ntpq -c kerninfo
associd=0 status=0015 leap_none, sync_unspec, 1 event, clock_sync,
kernel status:         pll nano
pll time constant:     5
pps frequency:         0
pps stability:         0
pps jitter:            0
calibration interval   0
calibration cycles:    0
jitter exceeded:       0
stability exceeded:    0
calibration errors:    0

No pll offset there.

> This defect bisects to the unlikely commit:
> 
> --8<---------------cut here---------------start------------->8---
> commit d5392adf5507eef85d58c5a082b13277ef45cf54
> Author: Gary E. Miller <gem at rellim.com>
> Date:   Wed Jan 30 17:33:36 2019 -0800
> 
>     ntp_control: Cleanup ctl_putdblf()
>     
>     replace pointer arithmetic with strlc**()
> 
> --8<---------------cut here---------------end--------------->8---
> 
> I have no idea how that is even possible, but it must have altered the
> built-in list of variables to print for kerninfo.

Or, maybe the variable is still there, but the new ctl_putfblf() is
no longer outputing that variable.  Some test of the double failing.

Thanks for the bisect.  I'll look now.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 851 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20190204/b026020e/attachment-0001.bin>