ntpd Stack Size

Richard Laager rlaager at wiktel.com
Mon Feb 19 05:53:19 UTC 2018


Is this NTP Classic issue applicable to ntpsec?

http://bugs.ntp.org/show_bug.cgi?id=3391
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887385

--- a/ntpd/ntpd.c      2017-03-27 08:33:16.690969527 +0200
+++ b/ntpd/ntpd.c      2017-03-27 08:33:16.690969527 +0200
@@ -313,11 +313,16 @@
 #if defined(HAVE_PTHREAD_ATTR_GETSTACKSIZE) && \
     defined(HAVE_PTHREAD_ATTR_SETSTACKSIZE) && \
     defined(PTHREAD_STACK_MIN)
-      rc = pthread_attr_setstacksize(&thr_attr, PTHREAD_STACK_MIN);
-      if (0 != rc)
-              msyslog(LOG_ERR,
-                      "my_pthread_warmup: pthread_attr_setstacksize() -> %s",
-                      strerror(rc));
+      {
+              size_t ssmin = 32*1024; /* 32kB should be minimum */
+              if (ssmin < PTHREAD_STACK_MIN)
+                      ssmin = PTHREAD_STACK_MIN;
+              rc = pthread_attr_setstacksize(&thr_attr, ssmin);
+              if (0 != rc)
+                      msyslog(LOG_ERR,
+                              "my_pthread_warmup: pthread_attr_setstacksize() -> %s",
+                              strerror(rc));
+      }
 #endif
       rc = pthread_create(
               &thread, &thr_attr, my_pthread_warmup_worker, NULL);

-- 
Richard


More information about the devel mailing list