✘gcc 8.2.0 warnings

[Gary E. Miller]

Yo Matthew!

On Fri, 31 Aug 2018 01:35:14 +0000
Matthew Selsky <Matthew.Selsky at twosigma.com> wrote:

> On Thu, Aug 30, 2018 at 06:21:49PM -0700, Gary E. Miller via devel
> wrote:
> 
> > I recently updated to gcc 8.2.0.  Of course it leads to new
> > warnings.  
> 
> Any idea why our gcc 8.2.0 CI job has no such warnings?  See
> https://gitlab.com/NTPsec/ntpsec/-/jobs/93445599

Looks like you do not have these options that I do:

    --enable-debug
    --enable-debug-gdb
    --enable-warnings
    --enable-doc
    --enable-seccomp

Probably this one: --enable-warnings

> How are you calling waf configure?  Anything different from what we
> do at https://gitlab.com/NTPsec/ntpsec/blob/master/.gitlab-ci.yml#L253

here is my config script:

./waf clean
./waf configure --enable-debug --enable-debug-gdb --enable-warnings \
   --refclock=all --enable-doc --enable-seccomp  && \
./waf build  && \
./waf install

I do not see you doing a .waf install either.

> I'd like to catch these warnings in CI before you see them :-)

Me too.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 851 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20180830/601baa6c/attachment.bin>