"Interesting" warnings from gcc 8.0.1

Hal Murray hmurray at megapathdsl.net
Sun Apr 8 11:52:48 UTC 2018


This is from gcc:
  gcc (GCC) 8.0.1 20180324 (Red Hat 8.0.1-0.20)
Which is shipping with Fedora 28 which is in beta.  (I'm testing on a Pi 3.)

../../ntpd/ntp_loopfilter.c:366:13: warning: passing argument 1 to 
restrict-qualified parameter aliases with argument 4 [-Wrestrict]
../../ntpd/ntp_loopfilter.c:370:13: warning: passing argument 1 to 
restrict-qualified parameter aliases with argument 4 [-Wrestrict]
...

The code looks like:
                if (ptimex->status & STA_UNSYNC)
                        snprintf(des, sizeof(des), "%s%sClock Unsynchronized",
                                des, (*des) ? "; " : "");

                if (ptimex->status & STA_CLOCKERR)
                        snprintf(des, sizeof(des), "%s%sClock Error",
                                des, (*des) ? "; " : "");
...

Looks like it is trying to append.  There must be a clean way to do that.  We 
haven't changed that code from ntp classic.

It's all part of ntp_adjtime_error_handler


-- 
These are my opinions.  I hate spam.





More information about the devel mailing list