✘Build failure

[Gary E. Miller]

Yo Matthew!

On Sat, 2 Sep 2017 21:28:20 -0400
Matthew Selsky via devel <devel at ntpsec.org> wrote:

> Are there extra options we should pass to ./waf configure to catch
> these types of errors in our gitlab bots?

Here is my formula:

./waf configure --enable-debug --enable-debug-gdb --enable-warnings \
 --refclock=all --enable-doc --enable-seccomp  && \
./waf build  && \
./waf install

It enables several extra paths that normal users normally do not
exercise.  There are some warings with that now:

asciidoc: WARNING: rollover.txt: line 210: missing section: [gps_pivots]
asciidoc: WARNING: rollover.txt: line 259: missing section: [ntp_pivots]

[...]

../../libntp/clocktime.c: In function 'clocktime':
../../libntp/clocktime.c:94:15: warning: conversion to 'uint32_t {aka unsigned int}' from 'int32_t {aka int}' may change the sign of the result [-Wsign-conversion]
      *ts_ui = (int32_t)*yearstart + tmp;
               ^

The --enbable-warnings is a bit troublesome as it does generate some
warnings that are not really fixable.

ntp_parser.tab.c: In function 'yytnamerr':
ntp_parser.tab.c:1391:34: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]
ntp_parser.tab.c: In function 'yysyntax_error':
ntp_parser.tab.c:1478:3: warning: switch missing default case [-Wswitch-default]
ntp_parser.tab.c: In function 'yyparse':
ntp_parser.tab.c:1637:25: warning: conversion to 'long unsigned int' from 'long int' may change the sign of the result [-Wsign-conversion]


AFAIK the only way to fix that one is to fix Bison.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170902/1393ec72/attachment.bin>