✘Build failure

[Fred Wright]

On Thu, 31 Aug 2017, Eric S. Raymond via devel wrote:

> Gary E. Miller via devel <devel at ntpsec.org>:
> > I just tried to build ntpsec for the first time in weeks.  Not good.
>
> Were you formerly getting these?
>
> ntp_parser.tab.c: In function ‘yytnamerr’:
> ntp_parser.tab.c:1329:21: warning: conversion to ‘long unsigned int’ from ‘long int’ may change the sign of the result [-Wsign-conversion]
> ntp_parser.tab.c:1391:10: note: in expansion of macro ‘yystpcpy’
> ntp_parser.tab.c: In function ‘yysyntax_error’:
> ntp_parser.tab.c:1478:3: warning: switch missing default case [-Wswitch-default]
> ntp_parser.tab.c: In function ‘yyparse’:
> ntp_parser.tab.c:1637:25: warning: conversion to ‘long unsigned int’ from ‘long int’ may change the sign of the result [-Wsign-conversion]
>
> I've fixed all the others.

Here I don't see build failures (admittedly without all Gary's options),
but I do see a test failure (OSX):

TEST(clocktime, CurrentYearExplicit)../../tests/libntp/clocktime.c:59::FAIL: Expected 3486372600 Was 104913720

This bisects to commit 5489ed5a593c8e14138e47544a1598d4c6576dee.

Fred Wright