✘ Bad Patch: nteger handling issues (SIGN_EXTENSION).

[Gary E. Miller]

Yo Eric!

On Thu, 11 May 2017 14:37:53 -0400
"Eric S. Raymond" <esr at thyrsus.com> wrote:

> I don't suppose it will surprise you to hear that I'm not seeing
> those warnings.

Bevause you do not have --enable-warnings on.  The only reason
-Wsign-conversion is not on all the time is because of the
known and documented Bison problems.

> Do you have any good ideas about how to fix them?

I'm not familiar with coverity.  I reverted that commit and now
gcc is happy again.  So the issue is how to make coverity happy.

> Please don't just go backward;

Not my intent, but not understanding coverity I'm not sure how to go
forward.  I'm open to ideas.

 Coverity was clearly right about the previous cast of
> the return value being broken.

We'll have to disagree on that one.  I do not agree the previous cast
was broken.  I has always been there, and in fact was there after your
change too.  The cast was an implicit cast, I changed it to explicit,
you just changed it back to implicit.`  But the gcc always performed
as if the ast was there.

Signed/unsigned integer casts make no functional change to machine code.
They just shut up compiler warnings.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170511/c7c389bb/attachment.bin>