Blizzard of warnings from -Wcast-align

[Gary E. Miller]

Yo Hal!

On Sun, 07 May 2017 11:21:43 -0700
Hal Murray via devel <devel at ntpsec.org> wrote:

> Can these be fixed, 

Not only can be fixed, but should be.  I'm thinking one union
will fix them all.  On some CPUs the alignment errors
can fatal.  Mostly on sipler CPUs.

But I feel the bug reports are higher priority.  We gotta seem, and
be, responsive to the new users.

> or is it time to move -Wcast-align out of the
> mainline?

I'll move it back to --enable-debug-warnings.

> ../../ntpd/ntp_proto.c:818:6: warning: cast increases required
> alignment of target type [-Wcast-align]
>       (uint32_t*)rbufp->recv_space.X_recv_buffer,
> 
> ../../tests/libntp/macencrypt.c: In function
> ‘TEST_macencrypt_DecryptValid_â €™:
> ../../tests/libntp/macencrypt.c:51:26: warning: cast increases
> required alignment of target type [-Wcast-align]
>                           (uint32_t*)expectedPacket, packetLength,
> 20));
> 
> 
> If I comment out the cast-align, this is the only warning left.  It's
> from an old CentOS.  Anybody know what this is about?
> ntp_parser.tab.c:378:6: warning: "YYENABLE_NLS" is not defined
> ntp_parser.tab.c:1260:6: warning: "YYLTYPE_IS_TRIVIAL" is not defined
> 
> If we can't fix it, I can live with it like we lived with the old
> warning that I've forgotten about.  I think it was a sign/unsigned
> mismatch that couldn't be fixed due to a screwup in a system macro.
> 
> 
> 




RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170507/ae756a45/attachment.bin>