Closing issues - please include why
Eric S. Raymond
esr at thyrsus.com
Sun May 7 19:15:47 UTC 2017
Hal Murray <hmurray at megapathdsl.net>:
> You like to close issues, but frequently I can't figure out why. Here is a
> good example.
> https://gitlab.com/NTPsec/ntpsec/issues/296
>
> Did you fix something? Did you decide it's not a bug? Did you decide it is
> too hard to fix, or any fix would break something else? ...
>
> If you fixed something, please include the header info from the commit, and
> please include the issue number in the commit comment.
As it says: Eric S. Raymond @esr mentioned in commit e8455cce about 5 hours ago
If you had chased the link to the commit, you would have seen this:
Address GitLab issue #296: compiler warning (gcc 7.0.1): lfpfunc.c
Simplify some tests so they don't throw compiler warnings.
So this was a complete fix for the problem. Had I decided it was not a
bug, or too hard to fix, or whatever else, I would have left a closing
comment on the issue.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
Please consider contributing to my Patreon page at https://www.patreon.com/esr
so I can keep the invisible wheels of the Internet turning. Give generously -
the civilization you save might be your own.
More information about the devel
mailing list