Is that the right fix?

Gary E. Miller gem at rellim.com
Sun Mar 12 00:55:26 UTC 2017


Yo Hal!

On Sat, 11 Mar 2017 16:51:01 -0800
Hal Murray <hmurray at megapathdsl.net> wrote:

> -               for (i = 1; i <= CC_MAXCODE; i++)
> +           for (i = 1; i <= (int)CC_MAXCODE; i++)
> Removing the U works for me.

Which then breaks several other places.

The sooner we get -Wsign-conversion standard the sooner we stop
silently adding problems.

There is a ton of bad practice being hidden by the implicit casts.

Feel free to give it a try, just be sure to use the -W.  Could be
a week or two before I have the next 400 issues handled.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170311/b6bd5f47/attachment.bin>


More information about the devel mailing list