sandbox cleanup

[Gary E. Miller]

Yo Hal!

On Thu, 01 Jun 2017 16:09:40 -0700
Hal Murray <hmurray at megapathdsl.net> wrote:

> >> The cast to gid_t doesn't seem necessary.  (static gid_t sw_gid;)  
> > Depends on the OS, remove the cast and you'll get warnings.  
> 
> > The cast was added in commit
> > 6791d614ca5128882e6e16bb695c17c052ba5591 to fix warnings.  Checking
> > git log is usually the fastest way to answer many qustions.  
> 
> -               if (user && initgroups(user, (int)sw_gid)) {
> +               if (user && initgroups(user, (gid_t)sw_gid)) {
> 
> That didn't add a cast, it replaced a bogus one.

Feel free to change it.  Let CC decide who is right.

> There is a lump of variables, including gid_t that are
> defined at the module level yet only used inside the one subroutine
> in that module.

Yup, a lot of cruft has been removed, a lot left to remove.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170601/7d27546d/attachment.bin>