Rough edge to clean up

Eric S. Raymond esr at thyrsus.com
Tue Jan 31 06:46:38 UTC 2017


Hal Murray <hmurray at megapathdsl.net>:
> 
> esr at thyrsus.com said:
> > There are three uses in libntp/macencrypt.c.  Two of them are MAC
> > computations that do require crypto security.  You found the third, which
> > doesn't. The flag seems to be intended to tag hashes that don't require
> > crypto security, so we seem to be OK so far. 
> 
> If we need crypto security someplace in the package, why not take advantage 
> of it some other place?
> 
> My suggestion would be to just delete those 4 lines.

I am wary of that until I know what the flag is doing.

I have not gotten us this far by being careless about modifying code I
don't understand, and I'm not going to start now.

Instead, I'll research that flag.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>


More information about the devel mailing list