ntpkeygen patch

[Gary E. Miller]

Yo Daniel!

On Fri, 6 Jan 2017 18:16:23 -0500
Daniel Franke <dfoxfranke at gmail.com> wrote:

> I wish somebody had mentioned to me that we wrote ntpkeygen in Python
> last month so that I could have done a code review.

Slap Eric with a fish!  And thank you for the code review.

> I just
> looked at the Python 2.7 version (which is what #!/usr/bin/env/python
> is going to get you on most distro) and it doesn't have
> sys_getrandom() support. (but Python 3.5 does).

Could you submit a patch that conditionally uses sys_getrandom() if
it is available?

> Also, it's probably best not to pass anything at all as a seed
> argument to SystemRandom.

Yes, as previously mentioned, that will go away soon.

RGDS                                                 Veritas liberabit vos
GARY                                                     Quid est veritas?
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
gem at rellim.com  Tel:+1 541 382 8588
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170106/d116a576/attachment.bin>