ntpsec | Extra precision for avgint field in ntpmon (#247)

Hal Murray hmurray at megapathdsl.net
Wed Feb 22 12:09:13 UTC 2017

I can't figure out what's going on.

I claim the issue was bogus.  The code as it was before your change was 

We (at least I) want the extra precision so we can tell how bad abusive 
clients are.   I sent something saying that, but it didn't make it to the 
issue tracker.


Subject: Re: ntpsec | Extra precision for avgint field in ntpmon (#247)
From: Hal Murray <hmurray at megapathdsl.net>
Date: Tue, 14 Feb 2017 23:41:33 -0800
To: NTPsec / ntpsec <incoming+de76447fa58c87382b0bb5f061d57b6f at gitlab.com>
Cc: hmurray at megapathdsl.net

> avgint should be an integer, not a float.

That change is a feature, not a bug.  Otherwise you can't tell how abusive 
the bad guys are.

The first part is in classic, but the extra digit for under 1 sec isn't there 

$ ntpq -nc "mrulist mincount=1000 sort=avgint" | more
Ctrl-C will stop MRU retrieval and display partial results.
 lstint avgint rstr r m v  count rport remote address
  31563  0.054   90 . 3 4   1278 51028
  56670  0.055   90 . 3 4   2606 50692
  73116  0.056   90 . 3 3   2692 57520
  41847  0.068   90 . 3 3   2199 41144


Eric said:
> I pushed rthis change.  It tracks a post-fork revision in Classic.

I can't figure out what that is supposed to mean.  My first reading was that "this change" meant you were copying the code from Classic.  But that doesn't make sense since it was already there.

You seem to have removed the code I want, so maybe "this change" means a change implementing the request in the subject of the issue (which I claim is bogus).

These are my opinions.  I hate spam.

More information about the devel mailing list