current HEAD is broken on old gcc (and warnings on current clang)

[Gary E. Miller]

Yo Fred!

On Mon, 13 Feb 2017 13:02:49 -0800 (PST)
Fred Wright <fw at fwright.net> wrote:

> > > /usr/bin/ld: libntp/pymodule.c.2.o: relocation R_X86_64_PC32
> > > against symbol `progname' can not be used when making a shared
> > > object; recompile with -fPIC /usr/bin/ld: final link failed: Bad
> > > value collect2: error: ld returned 1 exit status  
> >
> > Yes, reported yesterday.  I'm working on a solution.
> >
> > What I need to know is the breakpoint between gccc versions that
> > fail and those that work.  
> 
> If it's going to use questionable compiler options, then it needs to
> have something in the configure phase that determines whether said
> options are legal.

As i said, working on it.  Expect a solution today.

> The notion that -O1 implies _FORTIFY_SOURCE=2 seems suspect, and
> here's something that suggests that that combination is suboptimal:

Just look in the: /usr/include/features.h

> The proper way to add (properly vetted) linker flags is via LDFLAGS,
> not by adding them to CFLAGS with -Wl.  The latter only works when
> compiling and linking are done in a single compiler invocation, which
> isn't always the case.

Preaching to the choir, it was not my patch.

> I suggest reverting 287a00b9a until a more judicious way to apply the
> appropriate options can be worked out.

Sorry, can't do that.  Can only move forward, not back.

> Note that one can always get
> the same effect temporarily for testing just by specifying
> CFLAGS/LDFLAGS on the command line.

Except doing that with buildbot is a PITA.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ntpsec.org/pipermail/devel/attachments/20170213/e0e8d7f3/attachment.bin>