Something broken with minpoll/maxpoll

Gary E. Miller gem at rellim.com
Sat Sep 24 21:44:18 UTC 2016


Yo Hal!

On Sat, 24 Sep 2016 13:30:29 -0700
Hal Murray <hmurray at megapathdsl.net> wrote:

> Some of my PPS refclocks are now ramping up the poll interval.
> I think there used to be some code that set maxpoll to minpoll for
> refclocks. Did you break that?

Yes.  That was me.  I was wondering how long until someone noticed.  I
left a FIXME at the problem area in ntp_config.c

		/* FIXME: 0 no longer a magic value */
		/* this needs to be fixed */
		if (maxpoll == 0)
			/* default maxpoll for
			 * refclocks is minpoll
			 */
			peer->maxpoll = peer->minpoll;

I'm gonna take another part of your patch as the start of my fix.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem at rellim.com  Tel:+1 541 382 8588
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ntpsec.org/pipermail/devel/attachments/20160924/3753391c/attachment.bin>


More information about the devel mailing list