Would you please check libntp/systime.c

Hal Murray hmurray at megapathdsl.net
Tue Jun 7 23:43:46 UTC 2016

esr at thyrsus.com said:
>> Why didn't any of the other tools notice this?  The code isn't 
>> complicated.
> I don't know.  It does seem like the sort of error a static analyzer should
> spot. 

Should we feed them a test case?

esr at thyrsus.com said:
> The assignment to tvlast doesn't make sense.  It's a local variable so goes 
> away with the return.
> Right, I've fixed it.  ...


> That logging code is really dodgy. It's unconditionally disabled in Classic.
> I fixed it, because I could, and then later broke it by deleting the tvlast
> setting.  I should probably just rip it out.

> I keep thinking that whenever I look at it, but it's kind of a cute use for
> those logging channels and I haven't been able to make myself pull the
> trigger yet. 

I vote to keep it.

These are my opinions.  I hate spam.

More information about the devel mailing list