Our testing needs work...

[Hal Murray]

esr at thyrsus.com said:
>> We could live with it: add a comment to the code and another wherever we 
>> claim (almost) no warnings left.
> I'm for living with it. 

OK.  I'll add a note when I get the chance.



> Here is what's happening.  The ctype functions formally take an int, but
> semantically take a char.  They're implemented by a macro that indexes a
> hidden array.  The compiler is complaining because the array is being
> indexed by an expression of non-integral type.  Which, in this case, is
> silly. 

Does it do the right thing with negative chars?  I'd expect it to sign extend 
and look ahead of the table.

Is the table 256 slots long or only 128?  (or 384 with a duplicate copy of 
the top half in front of the starting place)



esr at thyrsus.com said:
> There's probably an option to suppress this check that defaults on but your
> one build environment has inverted.  It would be nice to figure out what
> that is. 

NetBSD and FreeBSD.




-- 
These are my opinions.  I hate spam.