<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<h3>Amar Takhar pushed to branch master at <a href="https://gitlab.com/NTPsec/ntpsec">NTPsec / ntpsec</a></h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/e71a5aba9e22ebac4d16966593ab7e6b95354c6e">e71a5aba</a></strong>
<div>
<span>by Amar Takhar</span>
<i>at 2015-12-04T16:55:37Z</i>
</div>
<pre class='commit-message'>Rename ntpdig test filenames to something more sane.
Also remove CAPS.</pre>
</li>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/a516bf59de47abb2c1dd508acb05fd3b4f7eeb86">a516bf59</a></strong>
<div>
<span>by Amar Takhar</span>
<i>at 2015-12-04T16:57:09Z</i>
</div>
<pre class='commit-message'>Move file_handling.c to common_source.</pre>
</li>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/f51dce3b635a521d1f98f6432e8eb79c0d03c641">f51dce3b</a></strong>
<div>
<span>by Amar Takhar</span>
<i>at 2015-12-04T17:41:27Z</i>
</div>
<pre class='commit-message'>Remove debug printf.</pre>
</li>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/07e67022691b1e95277afb25cad71dcbd01859bc">07e67022</a></strong>
<div>
<span>by Amar Takhar</span>
<i>at 2015-12-04T17:54:04Z</i>
</div>
<pre class='commit-message'>Remove comment marker the change is permanent.</pre>
</li>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/f0d376651655ec8a652496a91754b5e05eab46ee">f0d37665</a></strong>
<div>
<span>by Amar Takhar</span>
<i>at 2015-12-04T17:55:26Z</i>
</div>
<pre class='commit-message'>Remove GETTIMEOFDAY macro.</pre>
</li>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/c27db01cdd6d9cc149de2425a2457f839863120d">c27db01c</a></strong>
<div>
<span>by Amar Takhar</span>
<i>at 2015-12-04T17:56:40Z</i>
</div>
<pre class='commit-message'>Merge branch 'tmp'</pre>
</li>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/841b29a341018ec35d525487b95193d3c8c66d81">841b29a3</a></strong>
<div>
<span>by Amar Takhar</span>
<i>at 2015-12-04T19:16:39Z</i>
</div>
<pre class='commit-message'>Add a simple EXPECT_DOUBLE_EQ macro.</pre>
</li>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1">99d9a0be</a></strong>
<div>
<span>by Amar Takhar</span>
<i>at 2015-12-04T19:18:58Z</i>
</div>
<pre class='commit-message'>Re-enable disabled IllegalCharInPort test.
This is actually doing the right thing, the printfs are sending spam to stdout
which makes it seem like it's failing.</pre>
</li>
</ul>
<h4>9 changed files:</h4>
<ul>
<li class='file-stats'>
<a href='#diff-0'>
tests/libntp/a_md5encrypt.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-1'>
tests/libntp/decodenetnum.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-2'>
tests/libntp/lfptostr.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-3'>
tests/ntpdig/keyFile.c
→
tests/ntpdig/key_file.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-4'>
tests/ntpdig/kodDatabase.c
→
tests/ntpdig/kod_database.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-5'>
tests/ntpdig/kodFile.c
→
tests/ntpdig/kod_file.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-6'>
tests/ntpdig/packetHandling.c
→
tests/ntpdig/packet_handling.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-7'>
tests/ntpdig/packetProcessing.c
→
tests/ntpdig/packet_processing.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-8'>
tests/wscript
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id='diff-0'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1#diff-0'>
<strong>
tests/libntp/a_md5encrypt.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/libntp/a_md5encrypt.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/libntp/a_md5encrypt.c
</span><span style="color: #aaaaaa">@@ -29,7 +29,7 @@ const char *packet = "ijklmnopqrstuvwx";
</span> const int packetLength = 16;
const int keyIdLength = 4;
const int digestLength = 16;
<span style="color: #000000;background-color: #ffdddd">-const int totalLength = 36; //XXX: error: initializer element is not constant packetLength + keyIdLength + digestLength;
</span><span style="color: #000000;background-color: #ddffdd">+const int totalLength = 36; //error: initializer element is not constant packetLength + keyIdLength + digestLength;
</span> const char *expectedPacket = "ijklmnopqrstuvwx\0\0\0\0\x0c\x0e\x84\xcf\x0b\xb7\xa8\x68\x8e\x52\x38\xdb\xbc\x1c\x39\x53";
TEST(a_md5encrypt, Encrypt) {
</code></pre>
<br>
</li>
<li id='diff-1'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1#diff-1'>
<strong>
tests/libntp/decodenetnum.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/libntp/decodenetnum.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/libntp/decodenetnum.c
</span><span style="color: #aaaaaa">@@ -108,5 +108,5 @@ TEST_GROUP_RUNNER(decodenetnum) {
</span> RUN_TEST_CASE(decodenetnum, IPv6AddressOnly);
RUN_TEST_CASE(decodenetnum, IPv6AddressWithPort);
RUN_TEST_CASE(decodenetnum, IllegalAddress);
<span style="color: #000000;background-color: #ffdddd">-//XXX RUN_TEST_CASE(decodenetnum, IllegalCharInPort); Expected sa_family: 2 but got: 188
</span><span style="color: #000000;background-color: #ddffdd">+ RUN_TEST_CASE(decodenetnum, IllegalCharInPort);
</span> }
</code></pre>
<br>
</li>
<li id='diff-2'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1#diff-2'>
<strong>
tests/libntp/lfptostr.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/libntp/lfptostr.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/libntp/lfptostr.c
</span><span style="color: #aaaaaa">@@ -30,7 +30,6 @@ static const int HALF_PROMILLE_DOWN = 2147483; // slightly less than 0.0005
</span>
TEST(lfptostr, PositiveInteger) {
<span style="color: #000000;background-color: #ffdddd">- printf("beeeeeeeeeeer: %d\n", THREE_FOURTH);
</span> l_fp test = {{200}, 0}; // exact 200.0000000000
TEST_ASSERT_EQUAL_STRING("200.0000000000", mfptoa(test.l_ui, test.l_uf, LFP_MAX_PRECISION));
</code></pre>
<br>
</li>
<li id='diff-3'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1#diff-3'>
<strong>
tests/ntpdig/keyFile.c
</strong>
→
<strong>
tests/ntpdig/key_file.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/ntpdig/keyFile.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/ntpdig/key_file.c
</span></code></pre>
<br>
</li>
<li id='diff-4'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1#diff-4'>
<strong>
tests/ntpdig/kodDatabase.c
</strong>
→
<strong>
tests/ntpdig/kod_database.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/ntpdig/kodDatabase.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/ntpdig/kod_database.c
</span></code></pre>
<br>
</li>
<li id='diff-5'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1#diff-5'>
<strong>
tests/ntpdig/kodFile.c
</strong>
→
<strong>
tests/ntpdig/kod_file.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/ntpdig/kodFile.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/ntpdig/kod_file.c
</span></code></pre>
<br>
</li>
<li id='diff-6'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1#diff-6'>
<strong>
tests/ntpdig/packetHandling.c
</strong>
→
<strong>
tests/ntpdig/packet_handling.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/ntpdig/packetHandling.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/ntpdig/packet_handling.c
</span><span style="color: #aaaaaa">@@ -9,10 +9,13 @@
</span> #include "ntp.h"
#include <sys/time.h>
<span style="color: #000000;background-color: #ddffdd">+#include <stdlib.h>
</span>
<span style="color: #000000;background-color: #ffdddd">-#define GETTIMEOFDAY gettimeofday /* XXX: why? */
-#define EXPECT_DOUBLE_EQ(a, b) {} /* XXX: Not part of Unity */
</span>
<span style="color: #000000;background-color: #ddffdd">+#define EXPECT_DOUBLE_EQ(a, b) { \
+ float max = 0.0000000001; \
+ TEST_ASSERT_TRUE(abs(a - b) < max); \
+}
</span>
static bool LfpEquality(const l_fp* expected, const l_fp* actual) {
if (L_ISEQU(expected, actual)) {
<span style="color: #aaaaaa">@@ -34,11 +37,12 @@ TEST_SETUP(packetHandling) {}
</span> TEST_TEAR_DOWN(packetHandling) {}
TEST(packetHandling, GenerateUnauthenticatedPacket) {
<span style="color: #000000;background-color: #ddffdd">+
</span> struct pkt testpkt;
struct timeval xmt;
l_fp expected_xmt, actual_xmt;
<span style="color: #000000;background-color: #ffdddd">- GETTIMEOFDAY(&xmt, NULL);
</span><span style="color: #000000;background-color: #ddffdd">+ gettimeofday(&xmt, NULL);
</span> xmt.tv_sec += JAN_1970;
TEST_ASSERT_EQUAL(LEN_PKT_NOMAC,
<span style="color: #aaaaaa">@@ -70,7 +74,7 @@ TEST(packetHandling, GenerateAuthenticatedPacket) {
</span> memcpy(testkey.key_seq, "123456789", testkey.key_len);
memcpy(testkey.type, "MD5", 3);
<span style="color: #000000;background-color: #ffdddd">- GETTIMEOFDAY(&xmt, NULL);
</span><span style="color: #000000;background-color: #ddffdd">+ gettimeofday(&xmt, NULL);
</span> xmt.tv_sec += JAN_1970;
TEST_ASSERT_EQUAL(EXPECTED_PKTLEN,
</code></pre>
<br>
</li>
<li id='diff-7'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1#diff-7'>
<strong>
tests/ntpdig/packetProcessing.c
</strong>
→
<strong>
tests/ntpdig/packet_processing.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/ntpdig/packetProcessing.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/ntpdig/packet_processing.c
</span></code></pre>
<br>
</li>
<li id='diff-8'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1#diff-8'>
<strong>
tests/wscript
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/tests/wscript
</span><span style="color: #000000;background-color: #ddffdd">+++ b/tests/wscript
</span><span style="color: #aaaaaa">@@ -19,18 +19,18 @@ def build(ctx):
</span> common_source = [
"common/tests_main.c",
"common/caltime.c",
<span style="color: #000000;background-color: #ffdddd">- "common/sockaddrtest.c"
</span><span style="color: #000000;background-color: #ddffdd">+ "common/sockaddrtest.c",
+ "common/file_handling.c"
</span> ]
ntpdig_source = [
"ntpdig/crypto.c",
<span style="color: #000000;background-color: #ffdddd">- "common/file_handling.c",
- "ntpdig/keyFile.c",
- "ntpdig/kodDatabase.c",
- "ntpdig/kodFile.c",
- "ntpdig/packetHandling.c",
- "ntpdig/packetProcessing.c",
</span><span style="color: #000000;background-color: #ddffdd">+ "ntpdig/key_file.c",
+ "ntpdig/kod_database.c",
+ "ntpdig/kod_file.c",
+ "ntpdig/packet_handling.c",
+ "ntpdig/packet_processing.c",
</span> "ntpdig/utilities.c",
] + common_source
</code></pre>
<br>
</li>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="https://gitlab.com/NTPsec/ntpsec/compare/da0cfa0f701f61cfc0890f61f2ec1cb82791d084...99d9a0bed82cb02406ed83b6bb6fab69edbd3bc1">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can adjust your notification settings.
</p>
</div>
</body>
</html>