<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<h3>Eric S. Raymond pushed to branch master at <a href="https://gitlab.com/NTPsec/ntpsec">NTPsec / ntpsec</a></h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/2e1d5628b50dd8dd6207fa76e69b42582b8a52eb">2e1d5628</a></strong>
<div>
<span>by Eric S. Raymond</span>
<i>at 2015-12-02T08:07:29Z</i>
</div>
<pre class='commit-message'>Simopify intercept_sendpkt() by using socktoa().</pre>
</li>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/bee0a60cc7558e8fc979534618a0cd7204e2deb1">bee0a60c</a></strong>
<div>
<span>by Eric S. Raymond</span>
<i>at 2015-12-02T14:12:45Z</i>
</div>
<pre class='commit-message'>Add a link to Mills on Mills-speak.</pre>
</li>
</ul>
<h4>2 changed files:</h4>
<ul>
<li class='file-stats'>
<a href='#diff-0'>
docs/ntpspeak.txt
</a>
</li>
<li class='file-stats'>
<a href='#diff-1'>
ntpd/ntp_intercept.c
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id='diff-0'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/dad92dab379a5e756244c85bdb8d615429586029...bee0a60cc7558e8fc979534618a0cd7204e2deb1#diff-0'>
<strong>
docs/ntpspeak.txt
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/docs/ntpspeak.txt
</span><span style="color: #000000;background-color: #ddffdd">+++ b/docs/ntpspeak.txt
</span><span style="color: #aaaaaa">@@ -126,7 +126,10 @@ Mills-speak::
</span> wrote in a vivid and idiosyncratic style which is still preserved in
much of NTP's documentation. He coined many neologisms which
connoisseurs refer to as "Mills-speak"; examples in this glossary
<span style="color: #000000;background-color: #ffdddd">- include <<falseticker>>, <<proventic>>, and <<truechimer>>.
</span><span style="color: #000000;background-color: #ddffdd">+ include <<falseticker>>, <<proventic>>, and <<truechimer>>. The
+ close-to-definitive reference is
+ http://lists.ntp.org/pipermail/questions/2007-December/016592.html[The
+ NTP dictionary], though not all those terms are still in use.
</span>
[[NIST]]
NIST::
</code></pre>
<br>
</li>
<li id='diff-1'>
<a href='https://gitlab.com/NTPsec/ntpsec/compare/dad92dab379a5e756244c85bdb8d615429586029...bee0a60cc7558e8fc979534618a0cd7204e2deb1#diff-1'>
<strong>
ntpd/ntp_intercept.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/ntpd/ntp_intercept.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/ntpd/ntp_intercept.c
</span><span style="color: #aaaaaa">@@ -327,30 +327,20 @@ void intercept_sendpkt(const char *legend,
</span> sendpkt(dest, ep, ttl, pkt, len);
if (mode != none) {
<span style="color: #000000;background-color: #ffdddd">- char host[BUFSIZ], serv[BUFSIZ];
- /* sanity check: serv should always be "ntp" */
- int status = getnameinfo(&dest->sa, SOCKLEN(dest),
- host, sizeof(host),
- serv, sizeof(serv),
- NI_NUMERICSERV);
- if (status != 0)
- fprintf(stderr, "ntpd: getnameinfo() failed in intercept_sendpkt()\n");
- else {
- size_t i;
- printf("event sendpkt \"%s\" %s %s %d:%d:%d:%d:%u:%u:%u:%d:%d:%d:%d",
- legend, host, serv,
- pkt->li_vn_mode, pkt->stratum, pkt->ppoll, pkt->precision,
- /* FIXME: might be better to dump these in fixed-point */
- pkt->rootdelay, pkt->rootdisp,
- pkt->refid,
- /* FIXME: might be better to dump last 4 in fixed-point */
- pkt->reftime.l_uf, pkt->org.l_uf,
- pkt->rec.l_uf, pkt->xmt.l_uf);
- /* dump MAC as len - LEN_PKT_NOMAC chars in hex */
- for (i = 0; i < len - LEN_PKT_NOMAC; i++)
- printf("%02x", pkt->exten[i]);
- fputs("\n", stdout);
- }
</span><span style="color: #000000;background-color: #ddffdd">+ size_t i;
+ printf("event sendpkt \"%s\" %s %d:%d:%d:%d:%u:%u:%u:%d:%d:%d:%d",
+ legend, socktoa(dest),
+ pkt->li_vn_mode, pkt->stratum, pkt->ppoll, pkt->precision,
+ /* FIXME: might be better to dump these in fixed-point */
+ pkt->rootdelay, pkt->rootdisp,
+ pkt->refid,
+ /* FIXME: might be better to dump last 4 in fixed-point */
+ pkt->reftime.l_uf, pkt->org.l_uf,
+ pkt->rec.l_uf, pkt->xmt.l_uf);
+ /* dump MAC as len - LEN_PKT_NOMAC chars in hex */
+ for (i = 0; i < len - LEN_PKT_NOMAC; i++)
+ printf("%02x", pkt->exten[i]);
+ fputs("\n", stdout);
</span> }
/* FIXME: replay logic goes here */
</code></pre>
<br>
</li>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="https://gitlab.com/NTPsec/ntpsec/compare/dad92dab379a5e756244c85bdb8d615429586029...bee0a60cc7558e8fc979534618a0cd7204e2deb1">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can adjust your notification settings.
</p>
</div>
</body>
</html>