<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<h3>Eric S. Raymond pushed to branch master at <a href="https://gitlab.com/NTPsec/ntpsec">NTPsec / ntpsec</a></h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a">c1804e28</a></strong>
<div>
<span>by Eric S. Raymond</span>
<i>at 2015-11-22T17:02:57Z</i>
</div>
<pre class='commit-message'>Finish -Wextra signedness cleanup.</pre>
</li>
</ul>
<h4>13 changed files:</h4>
<ul>
<li class='file-stats'>
<a href='#diff-0'>
include/parse.h
</a>
</li>
<li class='file-stats'>
<a href='#diff-1'>
libntp/decodenetnum.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-2'>
libntp/intercept.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-3'>
libntp/systime.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-4'>
ntpd/keyword-gen.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-5'>
ntpd/ntp_proto.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-6'>
ntpd/ntp_scanner.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-7'>
ntpd/refclock_gpsdjson.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-8'>
ntpd/refclock_jjy.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-9'>
ntpd/refclock_mx4200.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-10'>
ntpd/refclock_shm.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-11'>
ntpq/libntpq.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-12'>
pylib/configure.py
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id='diff-0'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-0'>
<strong>
include/parse.h
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/include/parse.h
</span><span style="color: #000000;background-color: #ddffdd">+++ b/include/parse.h
</span><span style="color: #aaaaaa">@@ -34,9 +34,9 @@
</span> /*
* some constants useful for GPS time conversion
*/
<span style="color: #000000;background-color: #ffdddd">-#define GPSORIGIN 2524953600UL /* NTP origin - GPS origin in seconds */
-#define GPSWRAP 990U /* assume week count less than this in the previous epoch */
-#define GPSWEEKS 1024U /* number of weeks until the GPS epch rolls over */
</span><span style="color: #000000;background-color: #ddffdd">+#define GPSORIGIN 2524953600 /* NTP origin - GPS origin in seconds */
+#define GPSWRAP 990 /* assume week count less than this in the previous epoch */
+#define GPSWEEKS 1024 /* number of weeks until the GPS epch rolls over */
</span>
/*
* state flags
</code></pre>
<br>
</li>
<li id='diff-1'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-1'>
<strong>
libntp/decodenetnum.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/libntp/decodenetnum.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/libntp/decodenetnum.c
</span><span style="color: #aaaaaa">@@ -98,7 +98,7 @@ decodenetnum(
</span> either NULL or pointing to the start of the port. Check
whether the IP is short enough to possibly be valid and
if so copy it into ip. */
<span style="color: #000000;background-color: #ffdddd">- if(ip_end - ip_start + 1 > sizeof ip) {
</span><span style="color: #000000;background-color: #ddffdd">+ if(ip_end - ip_start + 1 > (int)sizeof(ip)) {
</span> return false;
} else {
memcpy(ip, ip_start, ip_end - ip_start);
</code></pre>
<br>
</li>
<li id='diff-2'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-2'>
<strong>
libntp/intercept.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/libntp/intercept.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/libntp/intercept.c
</span><span style="color: #aaaaaa">@@ -169,7 +169,7 @@ void intercept_get_systime(const char *legend, l_fp *now)
</span> printf("event systime %s %ld %ld\n",
legend, (long)ts.tv_sec, ts.tv_nsec);
<span style="color: #000000;background-color: #ffdddd">- normalize_time(ts, sys_fuzz > 0.0 ? ntp_random() : 0UL, now);
</span><span style="color: #000000;background-color: #ddffdd">+ normalize_time(ts, sys_fuzz > 0.0 ? ntp_random() : 0, now);
</span> }
long intercept_ntp_random(const char *legend)
</code></pre>
<br>
</li>
<li id='diff-3'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-3'>
<strong>
libntp/systime.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/libntp/systime.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/libntp/systime.c
</span><span style="color: #aaaaaa">@@ -200,7 +200,7 @@ get_systime(
</span> {
struct timespec ts; /* seconds and nanoseconds */
get_ostime(&ts);
<span style="color: #000000;background-color: #ffdddd">- normalize_time(ts, sys_fuzz > 0.0 ? ntp_random() : 0UL, now);
</span><span style="color: #000000;background-color: #ddffdd">+ normalize_time(ts, sys_fuzz > 0.0 ? ntp_random() : 0, now);
</span> }
void
</code></pre>
<br>
</li>
<li id='diff-4'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-4'>
<strong>
ntpd/keyword-gen.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/ntpd/keyword-gen.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/ntpd/keyword-gen.c
</span><span style="color: #aaaaaa">@@ -708,7 +708,7 @@ populate_symb(
</span> while (NULL != fgets(line, sizeof(line), yh))
if (2 == sscanf(line, "#define %s %d", name, &token)
&& 'T' == name[0] && '_' == name[1] && token >= 0
<span style="color: #000000;background-color: #ffdddd">- && token < COUNTOF(symb)) {
</span><span style="color: #000000;background-color: #ddffdd">+ && token < (int)COUNTOF(symb)) {
</span>
symb[token] = estrdup(name);
if (strlen(name) > MAX_TOK_LEN) {
</code></pre>
<br>
</li>
<li id='diff-5'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-5'>
<strong>
ntpd/ntp_proto.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/ntpd/ntp_proto.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/ntpd/ntp_proto.c
</span><span style="color: #aaaaaa">@@ -3614,7 +3614,7 @@ fast_xmit(
</span> #ifdef DEBUG
if (debug)
printf(
<span style="color: #000000;background-color: #ffdddd">- "transmit: at %ld %s->%s mode %d len %d\n",
</span><span style="color: #000000;background-color: #ddffdd">+ "transmit: at %ld %s->%s mode %d len %zd\n",
</span> current_time, stoa(&rbufp->dstadr->sin),
stoa(&rbufp->recv_srcadr), xmode, sendlen);
#endif
<span style="color: #aaaaaa">@@ -3671,7 +3671,7 @@ fast_xmit(
</span> #ifdef DEBUG
if (debug)
printf(
<span style="color: #000000;background-color: #ffdddd">- "transmit: at %ld %s->%s mode %d keyid %08x len %d\n",
</span><span style="color: #000000;background-color: #ddffdd">+ "transmit: at %ld %s->%s mode %d keyid %08x len %zd\n",
</span> current_time, ntoa(&rbufp->dstadr->sin),
ntoa(&rbufp->recv_srcadr), xmode, xkeyid, sendlen);
#endif
</code></pre>
<br>
</li>
<li id='diff-6'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-6'>
<strong>
ntpd/ntp_scanner.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/ntpd/ntp_scanner.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/ntpd/ntp_scanner.c
</span><span style="color: #aaaaaa">@@ -743,7 +743,7 @@ yylex(void)
</span> }
i++;
<span style="color: #000000;background-color: #ffdddd">- if (i >= COUNTOF(yytext))
</span><span style="color: #000000;background-color: #ddffdd">+ if (i >= (int)COUNTOF(yytext))
</span> goto lex_too_long;
}
/* Pick up all of the string inside between " marks, to
<span style="color: #aaaaaa">@@ -757,7 +757,7 @@ yylex(void)
</span> while (EOF != (ch = lex_getch(lex_stack)) &&
ch != '"' && ch != '\n') {
yytext[i++] = (char)ch;
<span style="color: #000000;background-color: #ffdddd">- if (i >= COUNTOF(yytext))
</span><span style="color: #000000;background-color: #ddffdd">+ if (i >= (int)COUNTOF(yytext))
</span> goto lex_too_long;
}
/*
</code></pre>
<br>
</li>
<li id='diff-7'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-7'>
<strong>
ntpd/refclock_gpsdjson.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/ntpd/refclock_gpsdjson.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/ntpd/refclock_gpsdjson.c
</span><span style="color: #aaaaaa">@@ -1191,7 +1191,7 @@ json_object_lookup(
</span> tid = json_token_skip(ctx, tid); /* skip val */
} else if (strcmp(key, ctx->buf + ctx->tok[tid].start)) {
tid = json_token_skip(ctx, tid+1); /* skip key+val */
<span style="color: #000000;background-color: #ffdddd">- } else if (what < 0 || what == ctx->tok[tid+1].type) {
</span><span style="color: #000000;background-color: #ddffdd">+ } else if (what < 0 || what == (int)ctx->tok[tid+1].type) {
</span> return tid + 1;
} else {
break;
</code></pre>
<br>
</li>
<li id='diff-8'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-8'>
<strong>
ntpd/refclock_jjy.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/ntpd/refclock_jjy.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/ntpd/refclock_jjy.c
</span><span style="color: #aaaaaa">@@ -2692,7 +2692,7 @@ jjy_start_telephone ( int unit, struct peer *peer, struct jjyunit *up )
</span> iNumberOfDigitsOfPhoneNumber = iCommaCount = iCommaPosition = iFirstThreeDigitsCount = 0 ;
for ( i = 0 ; i < strlen( sys_phone[0] ) ; i ++ ) {
if ( isdigit( *(sys_phone[0]+i) ) ) {
<span style="color: #000000;background-color: #ffdddd">- if ( iFirstThreeDigitsCount < sizeof(sFirstThreeDigits)-1 ) {
</span><span style="color: #000000;background-color: #ddffdd">+ if ( iFirstThreeDigitsCount < (int)sizeof(sFirstThreeDigits)-1 ) {
</span> sFirstThreeDigits[iFirstThreeDigitsCount++] = *(sys_phone[0]+i) ;
}
iNumberOfDigitsOfPhoneNumber ++ ;
<span style="color: #aaaaaa">@@ -3884,7 +3884,7 @@ modem_receive ( struct recvbuf *rbufp )
</span> if ( debug ) {
char sResp [ 40 ] ;
size_t iCopyLen ;
<span style="color: #000000;background-color: #ffdddd">- iCopyLen = ( iLen <= sizeof(sResp)-1 ? iLen : sizeof(sResp)-1 ) ;
</span><span style="color: #000000;background-color: #ddffdd">+ iCopyLen = ( iLen <= (int)sizeof(sResp)-1 ? iLen : (int)sizeof(sResp)-1 ) ;
</span> strlcpy( sResp, pBuf, sizeof(sResp) ) ;
printf ( "refclock_jjy.c : modem_receive : iLen=%zd pBuf=[%s] iModemEvent=%d\n", iCopyLen, sResp, up->iModemEvent ) ;
}
</code></pre>
<br>
</li>
<li id='diff-9'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-9'>
<strong>
ntpd/refclock_mx4200.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/ntpd/refclock_mx4200.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/ntpd/refclock_mx4200.c
</span><span style="color: #aaaaaa">@@ -1443,7 +1443,7 @@ mx4200_pps(
</span> struct peer *peer
)
{
<span style="color: #000000;background-color: #ffdddd">- int temp_serial;
</span><span style="color: #000000;background-color: #ddffdd">+ u_int temp_serial;
</span> struct refclockproc *pp;
struct mx4200unit *up;
</code></pre>
<br>
</li>
<li id='diff-10'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-10'>
<strong>
ntpd/refclock_shm.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/ntpd/refclock_shm.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/ntpd/refclock_shm.c
</span><span style="color: #aaaaaa">@@ -596,7 +596,7 @@ shm_timer(
</span> cd.year, cd.month, cd.monthday,
cd.hour, cd.minute, cd.second,
(long)shm_stat.tvt.tv_nsec);
<span style="color: #000000;background-color: #ffdddd">- pp->lencode = (c < sizeof(pp->a_lastcode)) ? c : 0;
</span><span style="color: #000000;background-color: #ddffdd">+ pp->lencode = (c < (int)sizeof(pp->a_lastcode)) ? c : 0;
</span>
/* check 1: age control of local time stamp */
tt = shm_stat.tvc.tv_sec - shm_stat.tvr.tv_sec;
</code></pre>
<br>
</li>
<li id='diff-11'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-11'>
<strong>
ntpq/libntpq.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/ntpq/libntpq.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/ntpq/libntpq.c
</span><span style="color: #aaaaaa">@@ -308,7 +308,7 @@ int ntpq_read_associations ( u_short resultbuf[], int max_entries )
</span>
if (ntpq_dogetassoc()) {
<span style="color: #000000;background-color: #ffdddd">- if(numassoc < max_entries)
</span><span style="color: #000000;background-color: #ddffdd">+ if((int)numassoc < max_entries)
</span> max_entries = numassoc;
for (i=0;i<max_entries;i++)
<span style="color: #aaaaaa">@@ -373,7 +373,7 @@ int ntpq_read_associations ( u_short resultbuf[], int max_entries )
</span>
int ntpq_get_assoc_number ( associd_t associd )
{
<span style="color: #000000;background-color: #ffdddd">- int i;
</span><span style="color: #000000;background-color: #ddffdd">+ u_int i;
</span>
for (i=0;i<numassoc;i++) {
if (assoc_cache[i].assid == associd)
<span style="color: #aaaaaa">@@ -712,7 +712,7 @@ ntpq_get_assoc_clocktype(
</span> char dstadr[NI_MAXHOST];
char resultbuf[NTPQ_BUFLEN];
<span style="color: #000000;background-color: #ffdddd">- if (assoc_index < 0 || assoc_index >= numassoc)
</span><span style="color: #000000;background-color: #ddffdd">+ if (assoc_index < 0 || assoc_index >= (int)numassoc)
</span> return -1;
associd = assoc_cache[assoc_index].assid;
</code></pre>
<br>
</li>
<li id='diff-12'>
<a href='https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a#diff-12'>
<strong>
pylib/configure.py
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/pylib/configure.py
</span><span style="color: #000000;background-color: #ddffdd">+++ b/pylib/configure.py
</span><span style="color: #aaaaaa">@@ -38,7 +38,7 @@ def cmd_configure(ctx):
</span> ctx.define("DEBUG", 1)
ctx.env.BISONFLAGS += ["--debug"]
<span style="color: #000000;background-color: #ffdddd">- ctx.env.CFLAGS += ["-Wall"] # Default CFLAGS.
</span><span style="color: #000000;background-color: #ddffdd">+ ctx.env.CFLAGS += ["-Wall", "-Wextra"] # Default CFLAGS.
</span>
# Check target platform.
</code></pre>
<br>
</li>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.com/NTPsec/ntpsec/commit/c1804e2899398faa0a897d748d085f99d9ed2a2a"}}</script>
</p>
</div>
</body>
</html>