<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 23, 2016 at 1:08 PM, Gary E. Miller <span dir="ltr"><<a href="mailto:gem@rellim.com" target="_blank">gem@rellim.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Yo Eric!<br>
<br>
<br>
> These are valid because the invention and major uses of u_long in this<br>
> codebase predate the 64-bit transition - it may look like we're<br>
> narrowing size from 64 to 32 bits, but what we're actually doing is<br>
> replacing an earlier hack for guaranteeing 32-bit size by people<br>
> who cut their teeth on 16-bit ints.<br>
<br>
I disagree with this patch.<br>
<br>
-extern void authtrust (keyid_t, unsigned long);<br>
+extern void authtrust (keyid_t, unsigned int);<br>
<br>
In C, ints are not guaranteed to be longer than 16 bits.<br>
<br>
<a href="http://stackoverflow.com/questions/5256000/integer-size-in-c-depends-on-what#5256195" rel="noreferrer" target="_blank">http://stackoverflow.com/<wbr>questions/5256000/integer-<wbr>size-in-c-depends-on-what#<wbr>5256195</a><br>
<br></blockquote><div><br></div><div>See C99 "5.2.4.2.1 Sizes of integer types" for the normative definition. </div><div><br></div><div><a href="http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf">http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf</a> (pg 33 of PDF)</div><div><br></div><div>If you have expectations of precise size of integers rather than required</div><div>minimum, you should used the stdint.h types like int32_t and uint64_t.</div><div><br></div><div>--joel</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Remember the poor embedded people.<br>
<br>
RGDS<br>
GARY<br>
------------------------------<wbr>------------------------------<wbr>---------------<br>
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703<br>
<a href="mailto:gem@rellim.com">gem@rellim.com</a> Tel:<a href="tel:%2B1%20541%20382%208588" value="+15413828588">+1 541 382 8588</a><br>
<br>______________________________<wbr>_________________<br>
vc mailing list<br>
<a href="mailto:vc@ntpsec.org">vc@ntpsec.org</a><br>
<a href="http://lists.ntpsec.org/mailman/listinfo/vc" rel="noreferrer" target="_blank">http://lists.ntpsec.org/<wbr>mailman/listinfo/vc</a><br>
<br>______________________________<wbr>_________________<br>
devel mailing list<br>
<a href="mailto:devel@ntpsec.org">devel@ntpsec.org</a><br>
<a href="http://lists.ntpsec.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ntpsec.org/<wbr>mailman/listinfo/devel</a><br></blockquote></div><br></div></div>